]> git.ipfire.org Git - thirdparty/samba.git/commit
Revert "smbd: Fix CID 1504457 Resource leak"
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 5 Oct 2023 22:55:46 +0000 (11:55 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 13 Oct 2023 02:18:31 +0000 (02:18 +0000)
commit68fb12cb79751c4fce59ea981e7e36daa2023662
treec43a7b8ccaa89b9eab00096c2e6a0f62debd7526
parentdbf96126cb232d265a555eda38425d74f9b5e677
Revert "smbd: Fix CID 1504457 Resource leak"

We cannot free ‘enc’ — it may be a copy of ‘buffer’, in which parameter
both construct_reply_chain() and smb_request_done() pass arrays of
automatic storage duration!

Fixes CID 1505354.

This reverts commit a395f752f0748751d4ade533c41066903f26c2dd.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/smbd/smb1_process.c