]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
clocksource/drivers/timer-sp804: Fix an Oops when read_current_timer is called on...
authorStephen Eta Zhou <stephen.eta.zhou@gmail.com>
Thu, 25 Dec 2025 08:16:31 +0000 (16:16 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 20 Jan 2026 17:06:54 +0000 (18:06 +0100)
commit694921a93f3e3621e067afc545cedf6fe3b234a9
tree52bbcb0b9f76a5d7a037ee444d20bd3e6f15129d
parentf555fd9ebec9aefaa6281b457de27dd6cba1d168
clocksource/drivers/timer-sp804: Fix an Oops when read_current_timer is called on ARM32 platforms where the SP804 is not registered as the sched_clock.

On SP804, the delay timer shares the same clkevt instance with
sched_clock. On some platforms, when
sp804_clocksource_and_sched_clock_init is called with use_sched_clock
not set to 1, sched_clkevt is not properly initialized. However,
sp804_register_delay_timer is invoked unconditionally, and
read_current_timer() subsequently calls sp804_read on an uninitialized
sched_clkevt, leading to a kernel Oops when accessing
sched_clkevt->value.

Declare a dedicated clkevt instance exclusively for delay timer,
instead of sharing the same clkevt with sched_clock.  This ensures
that read_current_timer continues to work correctly regardless of
whether SP804 is selected as the sched_clock.

Fixes: 640594a04f11 ("clocksource/drivers/timer-sp804: Fix read_current_timer() issue when clock source is not registered")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512250520.APOMkYRQ-lkp@intel.com/
Signed-off-by: Stephen Eta Zhou <stephen.eta.zhou@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://patch.msgid.link/20251225-fix_timersp804-v2-1-a366d7157f58@gmail.com
drivers/clocksource/timer-sp804.c