]> git.ipfire.org Git - thirdparty/linux.git/commit
regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Fri, 7 Nov 2025 10:45:51 +0000 (10:45 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 7 Nov 2025 14:07:04 +0000 (14:07 +0000)
commit6985defd1d832f1dd9d1977a6a2cc2cef7632704
tree13578f25b00702d2549d65827b569dd25eb59ca6
parentaf9c8092d84244ca54ffb590435735f788e7a170
regmap: sdw-mbq: Reorder regmap_mbq_context struct for better packing

Avoid a hole in struct regmap_mbq_context by shuffling the members
slightly. Pahole before:

struct regmap_mbq_context {
        struct device *            dev;                  /*     0     8 */
        struct sdw_slave *         sdw;                  /*     8     8 */
        struct regmap_sdw_mbq_cfg  cfg;                  /*    16    32 */
        int                        val_size;             /*    48     4 */

        /* XXX 4 bytes hole, try to pack */

        bool                       (*readable_reg)(struct device *, unsigned int); /*    56     8 */

        /* size: 64, cachelines: 1, members: 5 */
        /* sum members: 60, holes: 1, sum holes: 4 */
};

Pahole after:

struct regmap_mbq_context {
        struct device *            dev;                  /*     0     8 */
        struct sdw_slave *         sdw;                  /*     8     8 */
        bool                       (*readable_reg)(struct device *, unsigned int); /*    16     8 */
        struct regmap_sdw_mbq_cfg  cfg;                  /*    24    32 */
        int                        val_size;             /*    56     4 */

        /* size: 64, cachelines: 1, members: 5 */
        /* padding: 4 */
};

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251107104551.1553526-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap-sdw-mbq.c