]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: uvcvideo: Avoid invalid memory access
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 1 Dec 2021 05:22:17 +0000 (06:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:51:11 +0000 (12:51 +0100)
commit69b06b05ff948314b6cf4367737fa0949ceffc77
tree48493bed9b4ef435eb4bdb507b0f0a22adc4ca1e
parent4e15cf870d2c748e45d45ffc4d5b1dc1b7d50120
media: uvcvideo: Avoid invalid memory access

commit f0577b1b6394f954903fcc67e12fe9e7001dafd6 upstream.

If mappings points to an invalid memory, we will be invalid accessing
it. Solve it by initializing the value of the variable mapping and by
changing the order in the conditional statement (to avoid accessing
mapping->id if not needed).

Fix:
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN NOPTI

Fixes: 6350d6a4ed487 ("media: uvcvideo: Set error_idx during ctrl_commit errors")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/uvc/uvc_ctrl.c