]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virbuftest: Cleanup code around virTestDifference()
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 30 Nov 2022 08:39:46 +0000 (09:39 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 1 Dec 2022 13:22:39 +0000 (14:22 +0100)
commit69bb187e82e3883e54c30bf074b528344f4eaf02
treeccefc6fd549f6defe10c488d03778e2de866b518
parentf3b049e8780ca4081bf34e43dcdc6577e9aba456
virbuftest: Cleanup code around virTestDifference()

Two things are happening here:

1) Call to virTestDifference() is guarded by '!result ||
   STRNEQ(result, _)' check. This is suboptimal since we have
   STRNEQ_NULLABLE().

2) There are couple of VIR_TEST_DEBUG() printings, which are
   useless. If debug is off they don't print anything, and if it
   is on, then much more information is printed by subsequent
   virTestDifference().

This makes the STRNEQ() + virTestDifference() combo look similar
to the rest of tests and thus can be picked up by spatch later.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
tests/virbuftest.c