]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
erofs: harden h_shared_count in erofs_init_inode_xattrs()
authorUtkal Singh <singhutkal015@gmail.com>
Tue, 17 Mar 2026 15:24:39 +0000 (15:24 +0000)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Mon, 30 Mar 2026 02:40:21 +0000 (10:40 +0800)
commit6a01f5478d208544c8ba5ddbd674ea660f1b7047
tree168e8476c40f2312a518bfd9c0e468a1f48c4cfc
parent7aaa8047eafd0bd628065b15757d9b48c5f9c07d
erofs: harden h_shared_count in erofs_init_inode_xattrs()

`u8 h_shared_count` indicates the shared xattr count of an inode. It is
read from the on-disk xattr ibody header, which should be corrupted if
the size of the shared xattr array exceeds the space available in
`xattr_isize`.

It does not cause harmful consequence (e.g. crashes), since the image is
already considered corrupted, it indeed results in the silent processing
of garbage metadata.

Let's harden it to report -EFSCORRUPTED earlier.

Signed-off-by: Utkal Singh <singhutkal015@gmail.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
fs/erofs/xattr.c