]> git.ipfire.org Git - thirdparty/gcc.git/commit
openmp: Fix up *_reduction clause handling with UDRs on PARM_DECLs [PR101167]
authorJakub Jelinek <jakub@redhat.com>
Wed, 23 Jun 2021 08:03:28 +0000 (10:03 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 10 May 2022 08:14:24 +0000 (10:14 +0200)
commit6a2724b37766b612e5b7695ed39042a5e707c971
tree782c01c22609cf73a905cc6ea512ef8c7e2d30db
parent1ca92f0c253283cdcd7b6afcbbcd37c1fdcda6d8
openmp: Fix up *_reduction clause handling with UDRs on PARM_DECLs [PR101167]

The following testcase FAILs, because the UDR combiner is invoked incorrectly.
lower_omp_rec_clauses expects that when it sets
DECL_VALUE_EXPR/DECL_HAS_VALUE_EXPR_P
for both the placeholder and the var that everything will be properly
regimplified, but as the variable in question is a PARM_DECL rather than
VAR_DECL, lower_omp_regimplify_p doesn't say that it should be regimplified
and so it is not.

2021-06-23  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/101167
* omp-low.c (lower_omp_regimplify_p): Regimplify also PARM_DECLs
and RESULT_DECLs that have DECL_HAS_VALUE_EXPR_P set.

* testsuite/libgomp.c-c++-common/task-reduction-15.c: New test.

(cherry picked from commit 679506c3830ea1a93c755413609bfac3538e2cbd)
gcc/omp-low.c
libgomp/testsuite/libgomp.c-c++-common/task-reduction-15.c [new file with mode: 0644]