]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_dump: tests: Correct test condition for invalid databases
authorAndres Freund <andres@anarazel.de>
Mon, 25 Sep 2023 18:50:02 +0000 (11:50 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 25 Sep 2023 19:10:48 +0000 (12:10 -0700)
commit6a3b19bbefd782605765c67990e9d8b4dd5e9f87
treea96d40e268d20418121cf0ea043ce577e535cad0
parentfdc7cf73b424e4da7b1e61e7467441622758a00a
pg_dump: tests: Correct test condition for invalid databases

For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the test
condition of one of the tests added in in c66a7d75e65. That doesn't make sense
for two reasons: 1) not_like isn't a valid test condition 2) the database
should not be dumped in any of the tests.  Due to 1), the test achieved its
goal, but clearly the formulation is confusing.  Instead use like => {}, with
a comment explaining why.

Reported-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
Backpatch: 11-, like c66a7d75e65
src/bin/pg_dump/t/002_pg_dump.pl