]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix issue with reading zero bytes in Gzip_read.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Oct 2025 16:44:20 +0000 (12:44 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Oct 2025 16:44:20 +0000 (12:44 -0400)
commit6a4009747c3687bf1fdfef5f0b75c33681f37a10
tree1315dc652bf33921ff2db57e19a263aa6180f168
parentde2b62f4758786ae353baf161acb4a43dd9e0c8c
Fix issue with reading zero bytes in Gzip_read.

pg_dump expects a read request of zero bytes to be a no-op; see for
example ReadStr().  Gzip_read got this wrong and falsely supposed
that the resulting gzret == 0 indicated an error.  We could complicate
that error-checking logic some more, but it seems best to just fall
out immediately when passed size == 0.

This bug breaks the nominally-supported case of manually gzip'ing
the toc.dat file within a directory-style dump, so back-patch to v16
where this code came in.  (Prior branches already have a short-circuit
for size == 0 before their only gzread call.)

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/3515357.1760128017@sss.pgh.pa.us
Backpatch-through: 16
src/bin/pg_dump/compress_gzip.c