]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tipc: fix RCU dereference race in tipc_aead_users_dec()
authorDaniel Hodges <hodgesd@meta.com>
Tue, 3 Feb 2026 14:56:21 +0000 (09:56 -0500)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Feb 2026 20:36:31 +0000 (12:36 -0800)
commit6a65c0cb0ff20b3cbc5f1c87b37dd22cdde14a1c
treede8257ddee3e4e1fd45d45661bb7351c710a53d2
parent48dec8d88af96039a4a17b8c2f148f2a4066e195
tipc: fix RCU dereference race in tipc_aead_users_dec()

tipc_aead_users_dec() calls rcu_dereference(aead) twice: once to store
in 'tmp' for the NULL check, and again inside the atomic_add_unless()
call.

Use the already-dereferenced 'tmp' pointer consistently, matching the
correct pattern used in tipc_aead_users_inc() and tipc_aead_users_set().

Fixes: fc1b6d6de220 ("tipc: introduce TIPC encryption & authentication")
Cc: stable@vger.kernel.org
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Daniel Hodges <hodgesd@meta.com>
Link: https://patch.msgid.link/20260203145621.17399-1-git@danielhodges.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/crypto.c