]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mnt: Fail collect_mounts when applied to unmounted mounts
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 7 Jan 2015 20:28:26 +0000 (14:28 -0600)
committerJiri Slaby <jslaby@suse.cz>
Tue, 26 May 2015 14:26:55 +0000 (16:26 +0200)
commit6ab282fe6d43027b3b1ef820b3798aae8fdb432b
treeaf88861bec1d312657979f7c5c91f11cdb521c46
parent0b8b97704fbe442b3bba7a2c7eba9113122abafd
mnt: Fail collect_mounts when applied to unmounted mounts

commit cd4a40174b71acd021877341684d8bb1dc8ea4ae upstream.

The only users of collect_mounts are in audit_tree.c

In audit_trim_trees and audit_add_tree_rule the path passed into
collect_mounts is generated from kern_path passed an audit_tree
pathname which is guaranteed to be an absolute path.   In those cases
collect_mounts is obviously intended to work on mounted paths and
if a race results in paths that are unmounted when collect_mounts
it is reasonable to fail early.

The paths passed into audit_tag_tree don't have the absolute path
check.  But are used to play with fsnotify and otherwise interact with
the audit_trees, so again operating only on mounted paths appears
reasonable.

Avoid having to worry about what happens when we try and audit
unmounted filesystems by restricting collect_mounts to mounts
that appear in the mount tree.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/namespace.c