]> git.ipfire.org Git - thirdparty/linux.git/commit
i2c: imx: Cancel hrtimer before clearing slave pointer
authorLiem <liem16213@gmail.com>
Mon, 29 Jun 2026 02:38:29 +0000 (10:38 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 28 Jul 2026 21:24:03 +0000 (23:24 +0200)
commit6ac7702b6cc2b94aaed9ef2d95bfbefcdc90061f
tree6e9bdc5f5cf846229d5877371345280f6a4f81d4
parentd64ec362c369bbc33833f7936d5f3a706b0d5c45
i2c: imx: Cancel hrtimer before clearing slave pointer

In i2c_imx_unreg_slave(), the slave pointer is set to NULL after
disabling interrupts.  However, a pending interrupt might already
have started the hrtimer (i2c_imx_slave_timeout) before the pointer
was cleared.  If the hrtimer fires after i2c_imx->slave is set to
NULL, the timer callback i2c_imx_slave_finish_op() will call
i2c_imx_slave_event() with a NULL slave pointer, which results in a
use-after-free / NULL pointer dereference.

Fix by canceling the hrtimer and waiting for it to complete after
disabling interrupts, before clearing the slave pointer.

Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")
Signed-off-by: Liem <liem16213@gmail.com>
Cc: <stable@vger.kernel.org> # v5.11+
Acked-by: Carlos Song <carlos.song@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260629023829.152651-3-liem16213@gmail.com
drivers/i2c/busses/i2c-imx.c