]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Disallow a digit as the first character of a variable name in pgbench.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 13 Jan 2021 19:52:49 +0000 (14:52 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 13 Jan 2021 19:52:49 +0000 (14:52 -0500)
commit6b045ca6cce01f1512af3438a8d4db4dc83b2d07
treea14f7ed134e0d5238f1c194d79973f107b12cb0a
parentc77f31171c8349d9ae4d6328be1922f06c5d590f
Disallow a digit as the first character of a variable name in pgbench.

The point of this restriction is to avoid trying to substitute variables
into timestamp literal values, which may contain strings like '12:34'.

There is a good deal more that should be done to reduce pgbench's
tendency to substitute where it shouldn't.  But this is sufficient to
solve the case complained of by Jaime Soler, and it's simple enough
to back-patch.

Back-patch to v11; before commit 9d36a3866, pgbench had a slightly
different definition of what a variable name is, and anyway it seems
unwise to change long-stable branches for this.

Fabien Coelho

Discussion: https://postgr.es/m/alpine.DEB.2.22.394.2006291740420.805678@pseudo
doc/src/sgml/ref/pgbench.sgml
src/bin/pgbench/pgbench.c