]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: bgmac: Drop free_netdev() from bgmac_enet_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 9 Nov 2022 15:01:36 +0000 (15:01 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:45:46 +0000 (17:45 +0100)
commit6b23993d5bef1959926099b060c3e803e1caec6b
tree385a7fd1cfbd0954791b8782b5deabc9cf8113dc
parent1f6a73b25dabdd5e1bb4ca67bc0ee544de8fefd3
net: bgmac: Drop free_netdev() from bgmac_enet_remove()

[ Upstream commit 6f928ab8ee9bfbcb0e631c47ea8a16c3d5116ff1 ]

netdev is allocated in bgmac_alloc() with devm_alloc_etherdev() and will
be auto released in ->remove and ->probe failure path. Using free_netdev()
in bgmac_enet_remove() leads to double free.

Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221109150136.2991171-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bgmac.c