]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: rawmidi: Drop register_mutex in snd_rawmidi_free()
authorTakashi Iwai <tiwai@suse.de>
Tue, 11 Oct 2022 07:01:46 +0000 (09:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:15:36 +0000 (13:15 +0200)
commit6b2baa49c8396e2cfdae9a9aab2790c554ea086f
tree2c17ffdc063fb0f65f7de498c3321d7cd74d6882
parent090f988f0415ff664667f85e4156e6109567e440
ALSA: rawmidi: Drop register_mutex in snd_rawmidi_free()

commit a70aef7982b012e86dfd39fbb235e76a21ae778a upstream.

The register_mutex taken around the dev_unregister callback call in
snd_rawmidi_free() may potentially lead to a mutex deadlock, when OSS
emulation and a hot unplug are involved.

Since the mutex doesn't protect the actual race (as the registration
itself is already protected by another means), let's drop it.

Link: https://lore.kernel.org/r/CAB7eexJP7w1B0mVgDF0dQ+gWor7UdkiwPczmL7pn91xx8xpzOA@mail.gmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221011070147.7611-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/rawmidi.c