]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: usbtmc: Fix erroneous generic_read ioctl return
authorDave Penkler <dpenkler@gmail.com>
Fri, 2 May 2025 07:09:41 +0000 (09:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:20:38 +0000 (08:20 +0200)
commit6b3a2d6fd2c7fbc9213974a2b1f82c3f693b454f
treef2de94a0ce27fe4bdb7c3a6af0d6d4bf623c3d72
parentd88d487cf85f2235a5b7083c33ff29a1be32d1ce
usb: usbtmc: Fix erroneous generic_read ioctl return

commit 4e77d3ec7c7c0d9535ccf1138827cb9bb5480b9b upstream.

wait_event_interruptible_timeout returns a long
The return value was being assigned to an int causing an integer overflow
when the remaining jiffies > INT_MAX which resulted in random error
returns.

Use a long return value, converting to the int ioctl return only on error.

Fixes: bb99794a4792 ("usb: usbtmc: Add ioctl for vendor specific read")
Cc: stable@vger.kernel.org
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250502070941.31819-4-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/usbtmc.c