]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
io_uring/eventfd: ensure io_eventfd_signal() defers another RCU period
authorJens Axboe <axboe@kernel.dk>
Wed, 8 Jan 2025 18:16:13 +0000 (11:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2025 12:34:47 +0000 (13:34 +0100)
commit6b63308c28987c6010b1180c72a6db4df6c68033
treed077b4734bef7c35d81edfd1597a3c61ea7da02d
parent3e871c1d51f9ffea70065c36a2d8615ffc3f05aa
io_uring/eventfd: ensure io_eventfd_signal() defers another RCU period

Commit c9a40292a44e78f71258b8522655bffaf5753bdb upstream.

io_eventfd_do_signal() is invoked from an RCU callback, but when
dropping the reference to the io_ev_fd, it calls io_eventfd_free()
directly if the refcount drops to zero. This isn't correct, as any
potential freeing of the io_ev_fd should be deferred another RCU grace
period.

Just call io_eventfd_put() rather than open-code the dec-and-test and
free, which will correctly defer it another RCU grace period.

Fixes: 21a091b970cd ("io_uring: signal registered eventfd to process deferred task work")
Reported-by: Jann Horn <jannh@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
io_uring/io_uring.c