]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers
authorAshutosh Desai <ashutoshdesai993@gmail.com>
Sun, 10 May 2026 20:31:28 +0000 (20:31 +0000)
committerLyude Paul <lyude@redhat.com>
Mon, 18 May 2026 18:01:45 +0000 (14:01 -0400)
commit6b89ba3dba2f583626fb693e47e951ffb8bf591f
treeb59ebe73105d0e621d3157b82bac1df3e53c50be
parent1a8f537f5a1eeac941f262fe73078d6b08ba83c0
drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers

Three sideband reply parsers read 16-bit fields as:

  val = (raw->msg[idx] << 8) | (raw->msg[idx+1]);

and check bounds only after the fact. When idx == raw->curlen,
raw->msg[idx+1] reads one byte past the received message data into
the following struct fields (curchunk_len, curchunk_idx, curlen).

Affected functions:
 - drm_dp_sideband_parse_enum_path_resources_ack()
   full_payload_bw_number and avail_payload_bw_number fields
 - drm_dp_sideband_parse_allocate_payload_ack()
   allocated_pbn field
 - drm_dp_sideband_parse_query_payload_ack()
   allocated_pbn field

Fix by using a single combined check (idx + 2 > curlen) before each
2-byte read. Since the check is strictly tighter than idx > curlen,
no separate step is needed.

Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)")
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: Ashutosh Desai <ashutoshdesai993@gmail.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
[added fixes tag]
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patch.msgid.link/20260510203128.2884846-1-ashutoshdesai993@gmail.com
drivers/gpu/drm/display/drm_dp_mst_topology.c