]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix sscanf limits in pg_dump
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 19 Oct 2021 10:59:50 +0000 (12:59 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 19 Oct 2021 10:59:50 +0000 (12:59 +0200)
commit6b96aafc67ac80590a8317ec6a0447e95a2b1f66
tree058801ed9fb6a2056885aff86d1927ba7bd8c3eb
parentf49bf8263459bcaf253ffa33b77648b69fb2bfed
Fix sscanf limits in pg_dump

Make sure that the string parsing is limited by the size of the
destination buffer.

The buffer is bounded by MAXPGPATH, and thus the limit must be
inserted via preprocessor expansion and the buffer increased by
one to account for the terminator. There is no risk of overflow
here, since in this case, the buffer scanned is smaller than the
destination buffer.

Backpatch all the way down to 9.6.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/B14D3D7B-F98C-4E20-9459-C122C67647FB@yesql.se
Backpatch-through: 9.6
src/bin/pg_dump/pg_backup_directory.c