]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
power_supply: twl4030_madc: Check return value of power_supply_register
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 20 Feb 2015 13:32:22 +0000 (14:32 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Sun, 17 May 2015 23:11:55 +0000 (19:11 -0400)
commit6bc373ff486aa65f3620bd9253e0b75d83f26150
tree155b94fd8faf3e562af33487bf75cbc2466f9833
parent6ec5fc3a8308e298002f81b37f605ff10669a8f9
power_supply: twl4030_madc: Check return value of power_supply_register

[ Upstream commit 68c3ed6fa7e0d69529ced772d650ab128916a81d ]

The return value of power_supply_register() call was not checked and
even on error probe() function returned 0. If registering failed then
during unbind the driver tried to unregister power supply which was not
actually registered.

This could lead to memory corruption because power_supply_unregister()
unconditionally cleans up given power supply.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: da0a00ebc239 ("power: Add twl4030_madc battery driver.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/power/twl4030_madc_battery.c