]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Wed, 15 Oct 2014 14:25:09 +0000 (16:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Nov 2014 17:23:13 +0000 (09:23 -0800)
commit6bee038ae16df1fc7cc82ae23808593f283c2521
tree66e49b0b7ea82ba14c025e004baf11793909bad9
parente5cb3367b6fde0c21983cf4deb38c9972a390c42
power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle

commit 0eaf437aa14949d2230aeab7364f4ab47901304a upstream.

The power_supply_get_by_phandle() on error returns ENODEV or NULL.
The driver later expects obtained pointer to power supply to be
valid or NULL. If it is not NULL then it dereferences it in
bq2415x_notifier_call() which would lead to dereferencing ENODEV-value
pointer.

Properly handle the power_supply_get_by_phandle() error case by
replacing error value with NULL. This indicates that usb charger
detection won't be used.

Fix also memory leak of 'name' if power_supply_get_by_phandle() fails
with NULL and probe should defer.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: faffd234cf85 ("bq2415x_charger: Add DT support")
[small fix regarding the missing ti,usb-charger-detection info message]
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/bq2415x_charger.c