]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwmon: (asus-ec-sensors) check sensor index in read_string()
authorAlexei Safin <a.safin@rosa.ru>
Thu, 24 Apr 2025 20:26:54 +0000 (23:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:15 +0000 (11:07 +0100)
commit6bf529ce84dccc0074dbc704e70aee4aa545057e
tree33f5a7dc368867f29a2e9b72ed0d4f2eae4517f1
parent4d9d6e4be09472aa72953caca3dbefdc27846170
hwmon: (asus-ec-sensors) check sensor index in read_string()

[ Upstream commit 25be318324563c63cbd9cb53186203a08d2f83a1 ]

Prevent a potential invalid memory access when the requested sensor
is not found.

find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
but its result was used without checking, which could lead to
undefined behavior when passed to get_sensor_info().

Add a proper check to return -EINVAL if sensor_index is negative.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
Signed-off-by: Alexei Safin <a.safin@rosa.ru>
Link: https://lore.kernel.org/r/20250424202654.5902-1-a.safin@rosa.ru
[groeck: Return error code returned from find_ec_sensor_index]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/asus-ec-sensors.c