]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: codecs: wsa884x: Correct Soundwire ports mask
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 26 Jul 2024 14:10:46 +0000 (16:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:21 +0000 (15:34 +0200)
commit6c3edc4dd32ec0c8fd4e1a2a51669b4c11576583
treebc69a644b2147fb0bc24b8c5db0df531048bbd5e
parent9cddf33a1c25f3cfd621a3fd4d109c295728639a
ASoC: codecs: wsa884x: Correct Soundwire ports mask

[ Upstream commit dcb6631d05152930e2ea70fd2abfd811b0e970b5 ]

Device has up to WSA884X_MAX_SWR_PORTS number of ports and the array
assigned to prop.sink_dpn_prop has 0..WSA884X_MAX_SWR_PORTS-1 elements.
On the other hand, GENMASK(high, low) creates an inclusive mask between
<high, low>, so we need the mask from 0 up to WSA884X_MAX_SWR_PORTS-1.

Theoretically, too wide mask could cause an out of bounds read in
sdw_get_slave_dpn_prop() in stream.c, however only in the case of buggy
driver, e.g. adding incorrect number of ports via
sdw_stream_add_slave().

Fixes: aa21a7d4f68a ("ASoC: codecs: wsa884x: Add WSA884x family of speakers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240726-asoc-wcd-wsa-swr-ports-genmask-v1-6-d4d7a8b56f05@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wsa884x.c