]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: ramfb video device doesn't support PCI address
authorJonathon Jongsma <jjongsma@redhat.com>
Thu, 25 Jun 2020 20:18:22 +0000 (15:18 -0500)
committerLaine Stump <laine@redhat.com>
Thu, 25 Jun 2020 23:47:41 +0000 (19:47 -0400)
commit6c560b2d3aa2b2e4ecec44270c814ff9faf5c484
tree41c9373cda5e625965f21df191d986f707b67b6c
parentfe3840eac792a6eeacef42429e66e42f10b2e299
qemu: ramfb video device doesn't support PCI address

Although a ramfb video device is not a PCI device, we don't currently
report an error for ramfb device definitions containing a PCI address.
However, a guest configured with such a device will fail to start:

    # virsh start test1
    error: Failed to start domain test1
    error: internal error: qemu unexpectedly closed the monitor: 2020-06-16T05:23:02.759221Z qemu-kvm: -device ramfb,id=video0,bus=pcie.0,addr=0x1: Device 'ramfb' can't go on PCIE bus

A better approach is to reject any device definitions that contain PCI
addresses.  While this is a change in behavior, any existing
configurations were non-functional.

https://bugzilla.redhat.com/show_bug.cgi?id=1847259

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
src/qemu/qemu_validate.c
tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c