]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KVM: use after free in kvm_ioctl_create_device()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Nov 2016 19:21:05 +0000 (22:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2016 06:16:19 +0000 (07:16 +0100)
commit6c69476139799ccf8d3e76edfc892c64ced80bc4
tree3f60fd4566fb9c1e76730fc32cd13dc4e52cfa06
parentff8b06b4efa608c9d4d78f32df5ec7af8fcc9f0e
KVM: use after free in kvm_ioctl_create_device()

commit a0f1d21c1ccb1da66629627a74059dd7f5ac9c61 upstream.

We should move the ops->destroy(dev) after the list_del(&dev->vm_node)
so that we don't use "dev" after freeing it.

Fixes: a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
virt/kvm/kvm_main.c