]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pxa168fb: Fix the function used to release some memory in an error handling path
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 31 Aug 2019 10:00:24 +0000 (12:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:17 +0000 (15:42 +0100)
commit6ca731e5183143f0549f7c1df8d4927ca0179393
treed2d2b919beb6e2564704cf1820787ee6ba8b131f
parent86ddd143d5281fb3ee8305a655a2394109eed3b9
pxa168fb: Fix the function used to release some memory in an error handling path

[ Upstream commit 3c911fe799d1c338d94b78e7182ad452c37af897 ]

In the probe function, some resources are allocated using 'dma_alloc_wc()',
they should be released with 'dma_free_wc()', not 'dma_free_coherent()'.

We already use 'dma_free_wc()' in the remove function, but not in the
error handling path of the probe function.

Also, remove a useless 'PAGE_ALIGN()'. 'info->fix.smem_len' is already
PAGE_ALIGNed.

Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
CC: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190831100024.3248-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/pxa168fb.c