]> git.ipfire.org Git - thirdparty/elfutils.git/commit
elfcompress: Don't compress if section already compressed unless forced
authorMark Wielaard <mark@klomp.org>
Fri, 21 Apr 2023 23:45:43 +0000 (01:45 +0200)
committerMark Wielaard <mark@klomp.org>
Mon, 8 May 2023 16:14:15 +0000 (18:14 +0200)
commit6cad4e56a930034765f8e79ba2eaa2ff1cd8394f
tree9de41b3dbe84013dda5eea22169d02022736d885
parentfa7da8bfad1ec2ac61859aa0b4b09b42ea657ea2
elfcompress: Don't compress if section already compressed unless forced

Before commit a5b07cdf9 "support ZSTD compression algorithm"
elfcompress would not try to compress a section if it already
had the requested compression type (or was already uncompressed)
unless the --force flag was given. An else if construct was changed
to an if in the commit causing elfcompress to warn (in verbose mode)
but then still try to (re)compress the section.

Add an explicit check so if nothing needs (un)compressing, the file
isn't changed.

The diff looks large, but git diff -b -w is just:

+     if (force || type != schtype)
+       {
          if (shdr->sh_type != SHT_NOBITS
              && (shdr->sh_flags & SHF_ALLOC) == 0)
            {
@@ -554,6 +556,7 @@ process_file (const char *fname)
              printf ("[%zd] %s ignoring %s section\n", ndx, sname,
                      (shdr->sh_type == SHT_NOBITS ? "no bits" : "allocated"));
        }
+   }

Signed-off-by: Mark Wielaard <mark@klomp.org>
src/elfcompress.c