]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: libiscsi: Fix iscsi_prep_scsi_cmd_pdu() error handling
authorMike Christie <michael.christie@oracle.com>
Sun, 7 Feb 2021 04:46:00 +0000 (22:46 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 15:07:20 +0000 (16:07 +0100)
commit6cba890cc7ba1fb4a7e8f1586b247d89ffa22453
tree5ebe9dd0bdbdec1c0748c7ca639f4aa23a2d57f1
parentc0b91b440b6955cd873816bb124ee1c439a68634
scsi: libiscsi: Fix iscsi_prep_scsi_cmd_pdu() error handling

[ Upstream commit d28d48c699779973ab9a3bd0e5acfa112bd4fdef ]

If iscsi_prep_scsi_cmd_pdu() fails we try to add it back to the cmdqueue,
but we leave it partially setup. We don't have functions that can undo the
pdu and init task setup. We only have cleanup_task which can clean up both
parts. So this has us just fail the cmd and go through the standard cleanup
routine and then have the SCSI midlayer retry it like is done when it fails
in the queuecommand path.

Link: https://lore.kernel.org/r/20210207044608.27585-2-michael.christie@oracle.com
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/libiscsi.c