]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: SOF: Intel: hda: Place check before dereference
authorEthan Tidmore <ethantidmore06@gmail.com>
Tue, 24 Mar 2026 17:38:30 +0000 (12:38 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 31 Mar 2026 15:54:50 +0000 (16:54 +0100)
commit6cbc8360f51a3df2ea16a786b262b9fe44d4c68c
treefb84fa82ab6a029fa00e7ba9b8ccff8b9b4640f5
parent9968aad12f362dc686f139e1525d322a768f8ddb
ASoC: SOF: Intel: hda: Place check before dereference

The struct hext_stream is dereferenced before it is checked for NULL.
Although it can never be NULL due to a check prior to
hda_dsp_iccmax_stream_hw_params() being called, this change clears any
confusion regarding hext_stream possibly being NULL.

Check hext_stream for NULL and then assign its members.

Detected by Smatch:
sound/soc/sof/intel/hda-stream.c:488 hda_dsp_iccmax_stream_hw_params() warn:
variable dereferenced before check 'hext_stream' (see line 486)

Fixes: aca961f196e5d ("ASoC: SOF: Intel: hda: Add helper function to program ICCMAX stream")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Link: https://patch.msgid.link/20260324173830.17563-1-ethantidmore06@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-stream.c