]> git.ipfire.org Git - thirdparty/patchwork.git/commit
bin/pwclient: accept alternate http_proxy forms
authorYann E. MORIN <yann.morin.1998@free.fr>
Thu, 22 Dec 2016 21:09:32 +0000 (22:09 +0100)
committerStephen Finucane <stephen@that.guru>
Fri, 23 Dec 2016 23:10:25 +0000 (23:10 +0000)
commit6cf9468870936c7ee8229208e50ff16c85faab3f
treeeb759668eb40a57e54f165295be43a51ae7f5f6d
parent40496980e1883e872d50e615f7c1bf5ac0577f0c
bin/pwclient: accept alternate http_proxy forms

The forms for http_proxy (and the likes) is not very well defined nor
documented in any authoritaive place. However, there are two common
forms:  http://host:port  or  http://host:port/

Currently, the code chokes on the latter (e.g. with
http_proxy=http://127.0.0.1:8080/ ):

    [...]
      File "/usr/lib/python2.7/httplib.py", line 792, in _get_hostport
        raise InvalidURL("nonnumeric port: '%s'" % host[i+1:])
    httplib.InvalidURL: nonnumeric port: '8080/'

Chop off any slash character in the port definition to accept the second
form. If there is no '/' in there, it still works.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Stephen Finucane <stephenfinucane@hotmail.com>
patchwork/bin/pwclient