]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
userns: Check euid no fsuid when establishing an unprivileged uid mapping
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 6 Dec 2014 00:26:30 +0000 (18:26 -0600)
committerJiri Slaby <jslaby@suse.cz>
Wed, 7 Jan 2015 16:55:12 +0000 (17:55 +0100)
commit6cffb2520aba06a0df8ddbe0917175e07475431a
tree02dceabdbcc14cc32d4044307d7c9bbaa1f9805a
parentc75f0d0b9621f9654fcfb7cab7d7c13ed3898f3d
userns: Check euid no fsuid when establishing an unprivileged uid mapping

commit 80dd00a23784b384ccea049bfb3f259d3f973b9d upstream.

setresuid allows the euid to be set to any of uid, euid, suid, and
fsuid.  Therefor it is safe to allow an unprivileged user to map
their euid and use CAP_SETUID privileged with exactly that uid,
as no new credentials can be obtained.

I can not find a combination of existing system calls that allows setting
uid, euid, suid, and fsuid from the fsuid making the previous use
of fsuid for allowing unprivileged mappings a bug.

This is part of a fix for CVE-2014-8989.

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
kernel/user_namespace.c