]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
lib/test_kmod.c: potential double free in error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Feb 2019 22:20:58 +0000 (14:20 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Mar 2019 21:04:08 +0000 (14:04 -0700)
commit6d051009daca34e629b353e18cf0adb39ac88228
treeed65c69771b07b12ad574ba4e8813ec2732a839a
parent94ea61db81c6ab4e3f5e8c2c2735ad8e80ea3caa
lib/test_kmod.c: potential double free in error handling

[ Upstream commit db7ddeab3ce5d64c9696e70d61f45ea9909cd196 ]

There is a copy and paste bug so we set "config->test_driver" to NULL
twice instead of setting "config->test_fs".  Smatch complains that it
leads to a double free:

  lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed

Link: http://lkml.kernel.org/r/20190121140011.GA14283@kadam
Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/test_kmod.c