]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix get_dirent_type() for Windows junction points.
authorThomas Munro <tmunro@postgresql.org>
Fri, 22 Jul 2022 04:57:12 +0000 (16:57 +1200)
committerThomas Munro <tmunro@postgresql.org>
Fri, 22 Jul 2022 04:57:36 +0000 (16:57 +1200)
commit6d306ab731689ca01cdcafda9862732dcc075778
treeccd8f938b95a6351575a8582d0d3e47a4e931194
parent63a8c689b0d49b8f426c5075d37dd67a63e06f82
Fix get_dirent_type() for Windows junction points.

Commit 87e6ed7c8 added code that intended to report Windows "junction
points" as DT_LNK (the same way we report symlinks on Unix).  Windows
junction points are *also* directories according to the Windows
attributes API, and we were reporting them as as DT_DIR.  Change the
order we check the attribute flags, to prioritize DT_LNK.

If at some point we start using Windows' recently added real symlinks
and need to distinguish them from junction points, we may need to
rethink this, but for now this continues the tradition of wrapper
functions that treat junction points as symlinks.

Back-patch to 14, where get_dirent_type() landed.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com
Discussion: https://postgr.es/m/20220721111751.x7hod2xgrd76xr5c%40alvherre.pgsql
src/port/dirent.c