]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virStorageBackendRBDOpenRADOSConn: Don't log the RBD key
authorPeter Krempa <pkrempa@redhat.com>
Fri, 9 Dec 2022 15:49:12 +0000 (16:49 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 19 Dec 2022 13:40:26 +0000 (14:40 +0100)
commit6d661329dd1c426c5a46c678cf2e71b4ef2647e8
treeb36a379c9a991f3b4be25ce2dddd92672080e604
parent7df6338f4df4b053bb5d969d1dc63da7057cbca3
virStorageBackendRBDOpenRADOSConn: Don't log the RBD key

'virStorageBackendRBDRADOSConfSet' logs its arguments but it's also
used to set the RBD secret/key.

All the security theatre with securely erasing the string we do to fetch
the secret would be quite pointless if we log it thus introduce
virStorageBackendRBDRADOSConfSetQuiet and use it to avoid logging the
password.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/storage/storage_backend_rbd.c