]> git.ipfire.org Git - thirdparty/qemu.git/commit
pci/shpc: Do not unparent in instance_finalize()
authorAkihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Mon, 27 Oct 2025 01:24:18 +0000 (10:24 +0900)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 5 Feb 2026 08:18:39 +0000 (03:18 -0500)
commit6d8dd5ec084732a9933925aa2c4fdff9a1aae7ef
tree49fa5d8f2e12032715de8723e2e5622fdc12d409
parent196ac2544107121f64eeae5dccd2e72e72d55ab5
pci/shpc: Do not unparent in instance_finalize()

Children are automatically unparented so manually unparenting is
unnecessary.

Worse, automatic unparenting happens before the instance_finalize()
callback of the parent gets called, so object_unparent() calls in
the callback will refer to objects that are already unparented, which
is semantically incorrect.

Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20251027-shpc-v1-1-00e9b20a355d@rsg.ci.i.u-tokyo.ac.jp>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20251027-shpc-v1-1-00e9b20a355d@rsg.ci.i.u-tokyo.ac.jp>
hw/pci/shpc.c