]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
kbuild: rust-analyzer: better error handling
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 28 Jun 2024 00:43:55 +0000 (17:43 -0700)
committerMiguel Ojeda <ojeda@kernel.org>
Mon, 8 Jul 2024 21:44:01 +0000 (23:44 +0200)
commit6dc9d9ca9a728c8b30976d3ca353563ba0bfb949
treeb284290ffc8db6e49c9ccdbb3db30b9c2b02540e
parentb63c455d38be5f62a0665f3080c67334db5b4c41
kbuild: rust-analyzer: better error handling

1) Provide a better error message for the "Rust not available" case.
Without this patch, one gets various misleading messages, such as:

    "No rule to make target 'rust-analyzer'"

Instead, run scripts/rust_is_available.sh directly, as a prerequisite,
and let that script report the cause of any problems, as well as
providing a link to the documentation. Thanks to Miguel Ojeda for the
idea of just letting rust_is_available.sh report its results directly.

The new output in the failure case looks like this:

$ make rust-analyzer
***
*** Rust compiler 'rustc' could not be found.
***
***
*** Please see Documentation/rust/quick-start.rst for details
*** on how to set up the Rust support.
***
make[1]: *** [/kernel_work/linux-github/Makefile:1975: rust-analyzer] Error 1
make: *** [Makefile:240: __sub-make] Error 2

Reviewed-by: Finn Behrens <me@kloenk.dev>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Tested-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Link: https://lore.kernel.org/r/20240628004356.1384486-2-jhubbard@nvidia.com
[ Reworded title. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Makefile