]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KVM: emulate: fix CMPXCHG8B on 32-bit hosts
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 12 Feb 2015 16:04:47 +0000 (17:04 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 12 Mar 2015 16:31:11 +0000 (17:31 +0100)
commit6dd5cd79363d7aa0031e421b2909ed189e90ac2d
tree3fc45daa8dbc98c4a8d87227089869a7302079b9
parent377121bbc802ab818dcb028547e5c4440006f15f
KVM: emulate: fix CMPXCHG8B on 32-bit hosts

commit 4ff6f8e61eb7f96d3ca535c6d240f863ccd6fb7d upstream.

This has been broken for a long time: it broke first in 2.6.35, then was
almost fixed in 2.6.36 but this one-liner slipped through the cracks.
The bug shows up as an infinite loop in Windows 7 (and newer) boot on
32-bit hosts without EPT.

Windows uses CMPXCHG8B to write to page tables, which causes a
page fault if running without EPT; the emulator is then called from
kvm_mmu_page_fault.  The loop then happens if the higher 4 bytes are
not 0; the common case for this is that the NX bit (bit 63) is 1.

Fixes: 6550e1f165f384f3a46b60a1be9aba4bc3c2adad
Fixes: 16518d5ada690643453eb0aef3cc7841d3623c2d
Reported-by: Erik Rull <erik.rull@rdsoftware.de>
Tested-by: Erik Rull <erik.rull@rdsoftware.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/x86/kvm/emulate.c