]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Properly check index mark/restore in ExecSupportsMarkRestore.
authorAndrew Gierth <rhodiumtoad@postgresql.org>
Tue, 24 Nov 2020 20:58:32 +0000 (20:58 +0000)
committerAndrew Gierth <rhodiumtoad@postgresql.org>
Tue, 24 Nov 2020 21:16:58 +0000 (21:16 +0000)
commit6dda057043df4a56683e8fa31a74737b63da4c47
treed297deef8890d0383b1a8a3995f2d6f5ac3da8f6
parent340ae3cfb8f38a49664c0da3ff033346e92f0450
Properly check index mark/restore in ExecSupportsMarkRestore.

Previously this code assumed that all IndexScan nodes supported
mark/restore, which is not true since it depends on optional index AM
support functions. This could lead to errors about missing support
functions in rare edge cases of mergejoins with no sort keys, where an
unordered non-btree index scan was placed on the inner path without a
protecting Materialize node. (Normally, the fact that merge join
requires ordered input would avoid this error.)

Backpatch all the way since this bug is ancient.

Per report from Eugen Konkov on irc.

Discussion: https://postgr.es/m/87o8jn50be.fsf@news-spur.riddles.org.uk
src/backend/executor/execAmi.c
src/backend/optimizer/util/plancat.c
src/include/nodes/pathnodes.h