]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
thunderbolt: Fix double free of drom buffer
authorAndreas Noever <andreas.noever@gmail.com>
Sun, 10 Apr 2016 10:48:27 +0000 (12:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Jun 2016 19:18:04 +0000 (12:18 -0700)
commit6e3ef9021846959be412a77506906173118bf3f5
tree1de78e0054e3aa676ef92436cecb747771e01000
parent80772cfb1c98f38b939a776df6ebcca4e80726a3
thunderbolt: Fix double free of drom buffer

commit 2ffa9a5d76a75abbc1f95c17959fced666095bdd upstream.

If tb_drom_read() fails, sw->drom is freed but not set to NULL.  sw->drom
is then freed again in the error path of tb_switch_alloc().

The bug can be triggered by unplugging a thunderbolt device shortly after
it is detected by the thunderbolt driver.

Clear sw->drom if tb_drom_read() fails.

[bhelgaas: add Fixes:, stable versions of interest]
Fixes: 343fcb8c70d7 ("thunderbolt: Fix nontrivial endpoint devices.")
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/eeprom.c