]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: fix incorrect check for null pointer in header_assemble
authorSteve French <stfrench@microsoft.com>
Fri, 24 Sep 2021 00:18:37 +0000 (19:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 08:22:23 +0000 (10:22 +0200)
commit6e73e069615cdbf692b47ff52122e00cdc2076a1
treecfff142ce600a9228c3362ec86f5226e041b8556
parent5b1eba106df0a93f8d4a8e9120aba9c59328fba7
cifs: fix incorrect check for null pointer in header_assemble

commit 9ed38fd4a15417cac83967360cf20b853bfab9b6 upstream.

Although very unlikely that the tlink pointer would be null in this case,
get_next_mid function can in theory return null (but not an error)
so need to check for null (not for IS_ERR, which can not be returned
here).

Address warning:

        fs/smbfs_client/connect.c:2392 cifs_match_super()
        warn: 'tlink' isn't an ERR_PTR

Pointed out by Dan Carpenter via smatch code analysis tool

CC: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/connect.c