]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Input: rmi4 - initialize attn_fifo properly
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 11 Jun 2026 01:28:33 +0000 (18:28 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 12 Jun 2026 05:39:27 +0000 (22:39 -0700)
commit6e752b35b65228a948fc9e7dea51abb70da8b114
treea07680ac0e51391f18b19f64f52d90720f95d690
parent2b4b482d5c4c23c668b998a7da985aea0fa4a978
Input: rmi4 - initialize attn_fifo properly

attn_fifo is allocated as part of struct rmi_driver_data using
devm_kzalloc in rmi_driver_probe. However, it is never initialized.
A zero-initialized kfifo has its mask set to 0, which effectively
limits its capacity to 1 element instead of the declared 16.
This can lead to lost attention data and memory leaks of the attention
data payload if multiple attention events are received before the
threaded interrupt handler can process them.

Initialize attn_fifo using INIT_KFIFO after allocating rmi_driver_data.

Reported-by: sashiko-bot@kernel.org
Assisted-by: Antigravity:gemini-3.5-flash
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_driver.c