]> git.ipfire.org Git - thirdparty/gcc.git/commit
eliminate mutex in fast path of __register_frame
authorThomas Neumann <tneumann@users.sourceforge.net>
Tue, 1 Mar 2022 20:57:35 +0000 (21:57 +0100)
committerThomas Neumann <tneumann@users.sourceforge.net>
Fri, 16 Sep 2022 22:58:14 +0000 (00:58 +0200)
commit6e80a1d164d1f996ad08a512c000025a7c2ca893
tree650091c6cd09cfdc3daaa84492caa1213b18f348
parentcf0fded5d837bad590eb091d8a3dc4898872560f
eliminate mutex in fast path of __register_frame

The __register_frame/__deregister_frame functions are used to register
unwinding frames from JITed code in a sorted list. That list itself
is protected by object_mutex, which leads to terrible performance
in multi-threaded code and is somewhat expensive even if single-threaded.
There was already a fast-path that avoided taking the mutex if no
frame was registered at all.

This commit eliminates both the mutex and the sorted list from
the atomic fast path, and replaces it with a btree that uses
optimistic lock coupling during lookup. This allows for fully parallel
unwinding and is essential to scale exception handling to large
core counts.

libgcc/ChangeLog:

* unwind-dw2-fde.c (release_registered_frames): Cleanup at shutdown.
(__register_frame_info_table_bases): Use btree in atomic fast path.
(__deregister_frame_info_bases): Likewise.
(_Unwind_Find_FDE): Likewise.
(base_from_object): Make parameter const.
(classify_object_over_fdes): Add query-only mode.
(get_pc_range): Compute PC range for lookup.
* unwind-dw2-fde.h (last_fde): Make parameter const.
* unwind-dw2-btree.h: New file.
libgcc/unwind-dw2-btree.h [new file with mode: 0644]
libgcc/unwind-dw2-fde.c
libgcc/unwind-dw2-fde.h