]> git.ipfire.org Git - thirdparty/linux.git/commit
sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 4 Feb 2026 20:21:51 +0000 (21:21 +0100)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Mar 2026 01:25:09 +0000 (21:25 -0400)
commit6f57293abb8d087de830dd3f02e66d94b3e59973
tree19196acc297bfe829b12d7ae9d0e8b785c63f9d4
parentadcc59114ccd402259c089b0fea24da5e4974563
sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op

Clang compiler is not happy about set but unused variables:

.../flexfilelayout/flexfilelayoutdev.c:56:9: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
.../flexfilelayout/flexfilelayout.c:1505:6: error: variable 'err' set but not used [-Werror,-Wunused-but-set-variable]
.../nfs4proc.c:9244:12: error: variable 'ptr' set but not used [-Werror,-Wunused-but-set-variable]

Fix these by forwarding parameters of dprintk() to no_printk().
The positive side-effect is a format-string checker enabled even for the cases
when dprintk() is no-op.

Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Fixes: fc931582c260 ("nfs41: create_session operation")
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/lockd/svclock.c
include/linux/sunrpc/debug.h
include/linux/sunrpc/sched.h