]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ipv4: don't allow setting net.ipv4.route.min_pmtu below 68
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 26 Feb 2018 15:13:43 +0000 (16:13 +0100)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 21 Mar 2018 03:49:48 +0000 (23:49 -0400)
commit6f57f18ed1ff91744f14d392d3b810936a8e68fc
tree76b0eda6f3f2949ddf11f2654e863eef1b4fce9d
parentd2cd06ce649d483c4ec89ad2c3973204d1c66d5b
net: ipv4: don't allow setting net.ipv4.route.min_pmtu below 68

[ Upstream commit c7272c2f1229125f74f22dcdd59de9bbd804f1c8 ]

According to RFC 1191 sections 3 and 4, ICMP frag-needed messages
indicating an MTU below 68 should be rejected:

    A host MUST never reduce its estimate of the Path MTU below 68
    octets.

and (talking about ICMP frag-needed's Next-Hop MTU field):

    This field will never contain a value less than 68, since every
    router "must be able to forward a datagram of 68 octets without
    fragmentation".

Furthermore, by letting net.ipv4.route.min_pmtu be set to negative
values, we can end up with a very large PMTU when (-1) is cast into u32.

Let's also make ip_rt_min_pmtu a u32, since it's only ever compared to
unsigned ints.

Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
net/ipv4/route.c