]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: scarlett2: Fix buffer overflow in config retrieval
authorSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Sat, 17 Jan 2026 01:27:06 +0000 (17:27 -0800)
committerTakashi Iwai <tiwai@suse.de>
Sat, 17 Jan 2026 08:32:51 +0000 (09:32 +0100)
commit6f5c69f72e50d51be3a8c028ae7eda42c82902cb
tree01a62d451a88f1d287fc1acde72dadec0e0405c6
parent6b971191fcfc9e3c2c0143eea22534f1f48dbb62
ALSA: scarlett2: Fix buffer overflow in config retrieval

The scarlett2_usb_get_config() function has a logic error in the
endianness conversion code that can cause buffer overflows when
count > 1.

The code checks `if (size == 2)` where `size` is the total buffer size in
bytes, then loops `count` times treating each element as u16 (2 bytes).
This causes the loop to access `count * 2` bytes when the buffer only
has `size` bytes allocated.

Fix by checking the element size (config_item->size) instead of the
total buffer size. This ensures the endianness conversion matches the
actual element type.

Fixes: ac34df733d2d ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion")
Cc: stable@vger.kernel.org
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Link: https://patch.msgid.link/20260117012706.1715574-1-samasth.norway.ananda@oracle.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_scarlett2.c