]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sctp: translate host order to network order when setting a hmacid
authorlucien <lucien.xin@gmail.com>
Thu, 12 Nov 2015 05:07:07 +0000 (13:07 +0800)
committerZefan Li <lizefan@huawei.com>
Wed, 26 Oct 2016 15:15:28 +0000 (23:15 +0800)
commit6f67790b827dd495e7bf1bd874b8ad5ac6b3c0c4
tree1aea95a49b5091aa9510a2b0b8cffa77bb871187
parentbf4d43e3d2eb1a772e6ac915ffbb88e50f006cbf
sctp: translate host order to network order when setting a hmacid

commit ed5a377d87dc4c87fb3e1f7f698cba38cd893103 upstream.

now sctp auth cannot work well when setting a hmacid manually, which
is caused by that we didn't use the network order for hmacid, so fix
it by adding the transformation in sctp_auth_ep_set_hmacs.

even we set hmacid with the network order in userspace, it still
can't work, because of this condition in sctp_auth_ep_set_hmacs():

if (id > SCTP_AUTH_HMAC_ID_MAX)
return -EOPNOTSUPP;

so this wasn't working before and thus it won't break compatibility.

Fixes: 65b07e5d0d09 ("[SCTP]: API updates to suport SCTP-AUTH extensions.")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Zefan Li <lizefan@huawei.com>
net/sctp/auth.c