]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-35017, socketserver: don't accept request after shutdown (GH-9952) (GH-10129)
authorDenis Ledoux <be.ledoux.denis@gmail.com>
Fri, 26 Oct 2018 15:15:22 +0000 (17:15 +0200)
committerVictor Stinner <vstinner@redhat.com>
Fri, 26 Oct 2018 15:15:22 +0000 (17:15 +0200)
commit6f97a50c86737458c6bed9970c8dc31a465eff22
tree2c407526f34ebde18f0e2c94a319c3da7fa1ff6d
parent9dcb517f8ebba16a46ec2a6a97bb3e4a97daeae9
bpo-35017, socketserver: don't accept request after shutdown (GH-9952) (GH-10129)

Prior to this revision, after the shutdown of a `BaseServer`,
the server accepted a last single request
if it was sent between the server socket polling
and the polling timeout.

This can be problematic for instance for a server restart
for which you do not want to interrupt the service,
by not closing the listening socket during the restart.
One request failed because of this behavior.

Note that only one request failed,
following requests were not accepted, as expected.

(cherry picked from commit 10cb3760e8631a27f5db1e51b05494e29306c671)
Lib/SocketServer.py
Misc/NEWS.d/next/Library/2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rst [new file with mode: 0644]