]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()
authorJianglei Nie <niejianglei2021@163.com>
Thu, 14 Jul 2022 06:37:46 +0000 (14:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 13:16:15 +0000 (15:16 +0200)
commit700aa4e11a3c4d2a44d06758db431a013d9e1b61
tree95fff2d5d51e8d7145ca60d40e388161f79aca9a
parent3990e5b2be3d57325bcaf83da889e5ae212c97eb
mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()

[ Upstream commit 188043c7f4f2bd662f2a55957d684fffa543e600 ]

damon_reclaim_init() allocates a memory chunk for ctx with
damon_new_ctx().  When damon_select_ops() fails, ctx is not released,
which will lead to a memory leak.

We should release the ctx with damon_destroy_ctx() when damon_select_ops()
fails to fix the memory leak.

Link: https://lkml.kernel.org/r/20220714063746.2343549-1-niejianglei2021@163.com
Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
mm/damon/reclaim.c