]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: ccm - preserve the IV buffer
authorRomain Izard <romain.izard.pro@gmail.com>
Tue, 31 Oct 2017 14:42:35 +0000 (15:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Nov 2017 09:09:16 +0000 (10:09 +0100)
commit7014c9e0d0a8176ffdaebaef47450ef1302cafd7
tree908858cf1e3d5672378613ae0be8fc2494d76969
parentbd641333ef287e1c9f65a57624e5facad13889dd
crypto: ccm - preserve the IV buffer

commit 441f99c90497e15aa3ad1dbabd56187e29614348 upstream.

The IV buffer used during CCM operations is used twice, during both the
hashing step and the ciphering step.

When using a hardware accelerator that updates the contents of the IV
buffer at the end of ciphering operations, the value will be modified.
In the decryption case, the subsequent setup of the hashing algorithm
will interpret the updated IV instead of the original value, which can
lead to out-of-bounds writes.

Reuse the idata buffer, only used in the hashing step, to preserve the
IV's value during the ciphering step in the decryption case.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/ccm.c