]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net_sched: sch_sfq: use a temporary work area for validating configuration
authorOctavian Purdila <tavip@google.com>
Mon, 7 Apr 2025 20:24:07 +0000 (13:24 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:08 +0000 (10:15 +0200)
commit70449ca40609ec77f58b93ed154d54e1fdb197b6
tree2b9abd77e6ba0071ffd7c789f9a0ab815b3d4981
parentec12da4bcc44d5dd21679b3a0eb5e501e1a831a3
net_sched: sch_sfq: use a temporary work area for validating configuration

[ Upstream commit 8c0cea59d40cf6dd13c2950437631dd614fbade6 ]

Many configuration parameters have influence on others (e.g. divisor
-> flows -> limit, depth -> limit) and so it is difficult to correctly
do all of the validation before applying the configuration. And if a
validation error is detected late it is difficult to roll back a
partially applied configuration.

To avoid these issues use a temporary work area to update and validate
the configuration and only then apply the configuration to the
internal state.

Signed-off-by: Octavian Purdila <tavip@google.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Stable-dep-of: b3bf8f63e617 ("net_sched: sch_sfq: move the limit validation")
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_sfq.c